Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add subscribe to homepage #600

Closed
wants to merge 3 commits into from
Closed

Feat/add subscribe to homepage #600

wants to merge 3 commits into from

Conversation

sohaibaumer
Copy link

@sohaibaumer sohaibaumer commented Jul 6, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 874b339

Summary

🚚♻️🎨

Refactored the SubscribeForm component to a separate file src/layout/EmailSignup.jsx and added logic to customize its appearance based on the current page. This improves code reusability and consistency for email subscription forms across the website.

We're moving SubscribeForm to a new place
So we can use it on any page we face
With useLocation we can change the style
Heave away, me hearties, heave away with a smile

Walkthrough

  • Import useLocation hook to access current URL path in EmailSignUp component (link)
  • Add homeBackgroundStyle object to customize email sign up appearance on home page (link)
  • Use conditional style based on URL path in EmailSignUp component (link)
  • Move and export SubscribeForm component from BlogPage.jsx to EmailSignup.jsx for reusability (link)

@MaxGhenis
Copy link
Contributor

MaxGhenis commented Jul 6, 2023 •
edited
Loading

Could you please

  • Change your default quotes to avoid the extraneous diffs
  • Include a screenshot
  • Edit the original comment to include Fixes #598, so that merging the PR will close the issue

@sohaibaumer
Copy link
Author

ok

@sohaibaumer sohaibaumer closed this Jul 6, 2023
@sohaibaumer sohaibaumer deleted the feat/add-subscribe-to-homepage branch July 6, 2023 03:02
@MaxGhenis
Copy link
Contributor

For posterity, looks like you recreated this in #601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sohaibaumer @MaxGhenis